Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: runtime/vm/parser.cc

Issue 3001213002: [VM generic functions] Support generic async calls. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast_transformer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc
index b18c4fda87d1d1f08306b059046bd05ce0faa5a7..c7ee84e5214a821988dd74836764d49809f7e2cd 100644
--- a/runtime/vm/parser.cc
+++ b/runtime/vm/parser.cc
@@ -6980,7 +6980,6 @@ RawFunction* Parser::OpenSyncGeneratorFunction(TokenPosition func_pos) {
body = Function::NewClosureFunction(body_closure_name, innermost_function(),
func_pos);
body.set_is_generated_body(true);
- // TODO(regis): Handle generic generator function.
body.set_result_type(Object::dynamic_type());
is_new_closure = true;
}
@@ -7107,7 +7106,6 @@ RawFunction* Parser::OpenAsyncFunction(TokenPosition async_func_pos) {
closure = Function::NewClosureFunction(closure_name, innermost_function(),
async_func_pos);
closure.set_is_generated_body(true);
- // TODO(regis): Handle generic async function.
closure.set_result_type(Object::dynamic_type());
is_new_closure = true;
}
@@ -7240,7 +7238,6 @@ RawFunction* Parser::OpenAsyncGeneratorFunction(TokenPosition async_func_pos) {
closure = Function::NewClosureFunction(closure_name, innermost_function(),
async_func_pos);
closure.set_is_generated_body(true);
- // TODO(regis): Handle generic async generator function.
closure.set_result_type(Object::dynamic_type());
is_new_closure = true;
}
@@ -13811,7 +13808,6 @@ RawFunction* Parser::BuildConstructorClosureFunction(const Function& ctr,
closure.set_is_generated_body(true);
closure.set_is_debuggable(false);
closure.set_is_visible(false);
- // TODO(regis): Verify that the closure cannot be generic.
closure.set_result_type(Object::dynamic_type());
AddFormalParamsToFunction(&params, closure);
ResolveSignatureTypeParameters(closure);
« no previous file with comments | « runtime/vm/ast_transformer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698