Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3262)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/find_isolate.py

Issue 3001163002: Pinpoint - Surface info from executions for display in UI. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/find_isolate.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
index 11a2a20dc3558b0a7a89a0ac186a5135ed3db2fb..c21dae1b1ddefb8f3410e4d4b9f749bb547a40fa 100644
--- a/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
+++ b/dashboard/dashboard/pinpoint/models/quest/find_isolate.py
@@ -44,16 +44,25 @@ class _FindIsolateExecution(execution.Execution):
self._target = target
self._change = change
self._build = None
+ self._isolate_hash = ''
+
+ def _AsDict(self):
+ return {
+ 'build': self._build or '',
+ 'isolate_hash': self._isolate_hash,
+ }
def _Poll(self):
# Look for the .isolate in our cache.
try:
isolate_hash = isolate.Get(self._builder_name, self._change, self._target)
+ self._isolate_hash = isolate_hash
dtu 2017/08/21 23:52:53 Not a big fan of adding additional fields for this
shatch 2017/08/22 01:23:55 Removed.
except KeyError:
isolate_hash = None
if isolate_hash:
- self._Complete(result_arguments={'isolate_hash': isolate_hash})
+ self._Complete(
+ result_arguments={'isolate_hash': isolate_hash})
return
# Check the status of a previously requested build.

Powered by Google App Engine
This is Rietveld 408576698