Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2318)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/read_value.py

Issue 3001163002: Pinpoint - Surface info from executions for display in UI. (Closed)
Patch Set: Addressed comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/read_value.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/read_value.py b/dashboard/dashboard/pinpoint/models/quest/read_value.py
index e61bfc56fd955877d4b7349369c87c4370fd11f5..ca49e00e10e1719c7395dbe18c7865565afdda44 100644
--- a/dashboard/dashboard/pinpoint/models/quest/read_value.py
+++ b/dashboard/dashboard/pinpoint/models/quest/read_value.py
@@ -35,6 +35,11 @@ class _ReadChartJsonValueExecution(execution.Execution):
self._test = test or 'summary'
self._isolate_hash = isolate_hash
+ def _AsDict(self):
+ return {
+ 'isolate_hash': self._isolate_hash
+ }
+
def _Poll(self):
test_output = isolate_service.Retrieve(self._isolate_hash)
chartjson_isolate_hash = test_output['files']['chartjson-output.json']['h']
@@ -91,6 +96,11 @@ class _ReadGraphJsonValueExecution(execution.Execution):
self._trace = trace
self._isolate_hash = isolate_hash
+ def _AsDict(self):
+ return {
+ 'isolate_hash': self._isolate_hash
+ }
+
def _Poll(self):
test_output = isolate_service.Retrieve(self._isolate_hash)
graphjson_isolate_hash = test_output['files']['chartjson-output.json']['h']

Powered by Google App Engine
This is Rietveld 408576698