Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/execution.py

Issue 3001163002: Pinpoint - Surface info from executions for display in UI. (Closed)
Patch Set: Addressed comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/execution.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/execution.py b/dashboard/dashboard/pinpoint/models/quest/execution.py
index f7a89e4a73db21fab44d9a6383813ac5263a8a0a..35428b72c379ee7b2ca326f04bf9364bacf1e1bd 100644
--- a/dashboard/dashboard/pinpoint/models/quest/execution.py
+++ b/dashboard/dashboard/pinpoint/models/quest/execution.py
@@ -65,6 +65,17 @@ class Execution(object):
assert self.completed
return self._result_arguments
+ def AsDict(self):
+ d = {
+ 'result_arguments': self.result_arguments if self.completed else {},
+ 'result_values': self.result_values if self.completed else []
dtu 2017/08/22 16:46:19 nit: else null
shatch 2017/08/22 17:01:20 Done.
+ }
+ d.update(self._AsDict())
+ return d
+
+ def _AsDict(self):
+ raise NotImplementedError()
+
def Poll(self):
"""Update the Execution status."""
assert not self.completed

Powered by Google App Engine
This is Rietveld 408576698