Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: dashboard/dashboard/pinpoint/models/quest/run_test.py

Issue 3001163002: Pinpoint - Surface info from executions for display in UI. (Closed)
Patch Set: Addressed comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/pinpoint/models/quest/run_test.py
diff --git a/dashboard/dashboard/pinpoint/models/quest/run_test.py b/dashboard/dashboard/pinpoint/models/quest/run_test.py
index 3a4b90c2a3f80f75123a1c76aeccba43ed31adb0..9b8d40dcc83ff75a3a893d0bebb1ef5f27e0eb72 100644
--- a/dashboard/dashboard/pinpoint/models/quest/run_test.py
+++ b/dashboard/dashboard/pinpoint/models/quest/run_test.py
@@ -97,6 +97,13 @@ class _RunTestExecution(execution_module.Execution):
def bot_id(self):
return self._bot_id
+ def _AsDict(self):
+ return {
+ 'bot_id': self._bot_id or '',
perezju 2017/08/22 09:49:48 nit: ditto
+ 'task_id': self._task_id,
+ 'input_isolate_hash': self._isolate_hash,
+ }
+
def _Poll(self):
if not self._task_id:
self._StartTask()
@@ -117,8 +124,8 @@ class _RunTestExecution(execution_module.Execution):
if result['failure']:
raise SwarmingTestError(self._task_id, result['exit_code'])
- result_arguments = {'isolate_hash': result['outputs_ref']['isolated']}
- self._Complete(result_arguments=result_arguments)
+ self._Complete(
+ result_arguments={'isolate_hash': result['outputs_ref']['isolated']})
def _StartTask(self):

Powered by Google App Engine
This is Rietveld 408576698