Pinpoint - Surface info from executions for display in UI.

dashboard/dashboard/pinpoint/models/job.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import logging
 import os
 
 from google.appengine.api import taskqueue
 from google.appengine.ext import ndb
@@ skipping 252 matching lines @@
     result_values = []
     for change in self._changes:
       change_result_values = []
 
       change_results_per_quest = _CombineResultsPerQuest(self._attempts[change])
       for quest in self._quests:
         change_result_values.append(change_results_per_quest[quest])
 
       result_values.append(change_result_values)
 
+    execution_details = []

[dtu, 2017/08/21 23:52:52]

I don't see a clear advantage of this format over a list of attempts for each
Change.
{'attempts': [[attempt.AsDict() for attempt in self._attempts[change]] for
change in self._changes]}

result_values is aggregated in this way to provide a flat list for reach
(Change, Quest), but it's not clear we can/should do that for every piece of
data in execution_details.

[shatch, 2017/08/22 01:23:55]

Done.

+    for change in self._changes:
+      change_results_per_quest = _CombineExecutionDetailsPerQuest(
+          self._attempts[change])
+
+      change_result_values = []
+      for quest in self._quests:
+        change_result_values.append(change_results_per_quest[quest])
+
+      execution_details.append(change_result_values)
+
     return {
         'quests': map(str, self._quests),
         'changes': map(str, self._changes),
         'comparisons': comparisons,
         'result_values': result_values,
+        'execution_details': execution_details,

[dtu, 2017/08/21 23:52:52]

nit: executions

     }
 
   def _Compare(self, change_a, change_b):
     attempts_a = self._attempts[change_a]
     attempts_b = self._attempts[change_b]
 
     if any(not attempt.completed for attempt in attempts_a + attempts_b):
       return _PENDING
 
     results_a = _CombineResultsPerQuest(attempts_a)
@@ skipping 18 matching lines @@
   for attempt in attempts:
     if not attempt.completed:
       continue
 
     for quest, results in attempt.result_values.iteritems():
       aggregate_results[quest] += results
 
   return aggregate_results
 
 
+def _CombineExecutionDetailsPerQuest(attempts):
+  aggregate_results = collections.defaultdict(list)
+  for attempt in attempts:
+    for quest, results in attempt.AsDictPerQuest().iteritems():
+      aggregate_results[quest].append(results)
+
+  return aggregate_results
+
+
 def _CompareResults(results_a, results_b):
   if len(results_a) == 0 or len(results_b) == 0:
     return _UNKNOWN
 
   try:
     p_value = mann_whitney_u.MannWhitneyU(results_a, results_b)
   except ValueError:
     return _UNKNOWN
 
   if p_value < _SIGNIFICANCE_LEVEL:
     return _DIFFERENT
   else:
     return _UNKNOWN