Chromium Code Reviews| Index: chrome/browser/ui/cocoa/base_bubble_controller.mm |
| diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm |
| index 6dc573696ead2092213d8890b6db9d917a2d2f5f..b1f5c38763055be0f250c795ad3ac52a9306d277 100644 |
| --- a/chrome/browser/ui/cocoa/base_bubble_controller.mm |
| +++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm |
| @@ -241,15 +241,17 @@ |
| // The eventTap_ catches clicks within the application that are outside the |
| // window. |
| eventTap_ = [NSEvent |
| - addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask |
| + addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask | |
| + NSRightMouseDownMask |
| handler:^NSEvent* (NSEvent* event) { |
| if (event.window != window) { |
| - // Call via the runloop because this block is called in the |
| - // middle of event dispatch. |
| - [self performSelector:@selector(windowDidResignKey:) |
| - withObject:note |
| - afterDelay:0]; |
| - } |
| + // Do it right now, because if this event is right mouse event, |
| + // it may pop up a menu. windowDidResignKey: will not exec until |
|
Robert Sesek
2014/06/05 14:22:50
nit: exec -> execute/run. We don't abbreviate in c
|
| + // the menu is closed. |
| + if ([self respondsToSelector:@selector(windowDidResignKey:)]) { |
| + [self windowDidResignKey:note]; |
| + } |
| + } |
|
Robert Sesek
2014/06/05 14:22:50
nit: indent 1 more space
|
| return event; |
| }]; |