Fix BaseBubbleController close issue.

chrome/browser/ui/cocoa/base_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
@@ skipping 223 matching lines @@
     return;
 
   NSWindow* window = self.window;
   NSNotification* note =
       [NSNotification notificationWithName:NSWindowDidResignKeyNotification
                                     object:window];
 
   // The eventTap_ catches clicks within the application that are outside the
   // window.
   eventTap_ = [NSEvent
-      addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask
+      addLocalMonitorForEventsMatchingMask:NSLeftMouseDownMask |
+                                           NSRightMouseDownMask
       handler:^NSEvent* (NSEvent* event) {
           if (event.window != window) {
-            // Call via the runloop because this block is called in the
-            // middle of event dispatch.
-            [self performSelector:@selector(windowDidResignKey:)
-                       withObject:note
-                       afterDelay:0];
-          }
+            // Do it right now, because if this event is right mouse event,
+            // it may pop up a menu. windowDidResignKey will not exec untill

[Nico, 2014/05/28 08:50:15]

typo "until"

[Robert Sesek, 2014/05/28 19:47:03]

nit: add a : after windowDidResignKey (it's part of the name)

+            // the menu is closed.
+            if ([self respondsToSelector:@selector(windowDidResignKey:)]) {
+                        [self windowDidResignKey:note];

[Nico, 2014/05/28 08:50:15]

nit: this should be indented only 2 relative to the if

+            }
+         }
           return event;
       }];
 
   // The resignationObserver_ watches for when a window resigns key state,
   // meaning the key window has changed and the bubble should be dismissed.
   NSNotificationCenter* center = [NSNotificationCenter defaultCenter];
   resignationObserver_ =
       [center addObserverForName:NSWindowDidResignKeyNotification
                           object:nil
                            queue:[NSOperationQueue mainQueue]
@@ skipping 64 matching lines @@
 
 - (void)activateTabWithContents:(content::WebContents*)newContents
                previousContents:(content::WebContents*)oldContents
                         atIndex:(NSInteger)index
                          reason:(int)reason {
   // The user switched tabs; close.
   [self close];
 }
 
 @end  // BaseBubbleController