Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 3001103002: Do not qualify with dart:: except where necessary (Closed)

Created:
3 years, 4 months ago by Kevin Millikin (Google)
Modified:
3 years, 4 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not qualify with dart:: except where necessary The Kernel C++ implementation no longer has classes like Library, Class, Field, or String, so it's no longer necessary to explicitly write `dart::` in most places. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/a2712fc099df0720ee7f05cc0867729d618ab91e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -505 lines) Patch
M runtime/vm/bootstrap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_nocore.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/kernel.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 10 chunks +26 lines, -27 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 86 chunks +141 lines, -150 lines 0 comments Download
M runtime/vm/kernel_reader.h View 4 chunks +22 lines, -27 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 29 chunks +77 lines, -84 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 14 chunks +60 lines, -62 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 46 chunks +134 lines, -145 lines 0 comments Download
M runtime/vm/parser.h View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
This could certainly cause a bunch of silly little conflicts with ongoing CLs. But the ...
3 years, 4 months ago (2017-08-17 12:46:54 UTC) #2
jensj
lgtm
3 years, 4 months ago (2017-08-17 12:54:43 UTC) #3
Kevin Millikin (Google)
3 years, 4 months ago (2017-08-18 09:28:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2712fc099df0720ee7f05cc0867729d618ab91e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698