Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 3001093002: Remove some "namespace" classes from C++ Kernel (Closed)

Created:
3 years, 4 months ago by Kevin Millikin (Google)
Modified:
3 years, 4 months ago
Reviewers:
jensj
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove some "namespace" classes from C++ Kernel The C++ implementation of Kernel has some classes that are serving as namespaces for enums. Remove them. BUG= R=jensj@google.com Committed: https://github.com/dart-lang/sdk/commit/2f48593d9a813d091328d46f11c4a687a85992b5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+999 lines, -1061 lines) Patch
M runtime/vm/kernel.h View 1 chunk +2 lines, -68 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 2 chunks +957 lines, -949 lines 1 comment Download
M runtime/vm/kernel_binary_flowgraph.cc View 14 chunks +31 lines, -29 lines 0 comments Download
M runtime/vm/kernel_reader.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/kernel_reader.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Kevin Millikin (Google)
https://codereview.chromium.org/3001093002/diff/1/runtime/vm/kernel_binary_flowgraph.h File runtime/vm/kernel_binary_flowgraph.h (left): https://codereview.chromium.org/3001093002/diff/1/runtime/vm/kernel_binary_flowgraph.h#oldcode20 runtime/vm/kernel_binary_flowgraph.h:20: class StreamingDartTypeTranslator { The ...Helper classes were just moved ...
3 years, 4 months ago (2017-08-17 12:29:25 UTC) #2
jensj
lgtm
3 years, 4 months ago (2017-08-17 12:32:33 UTC) #3
Kevin Millikin (Google)
3 years, 4 months ago (2017-08-17 12:34:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f48593d9a813d091328d46f11c4a687a85992b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698