Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 3001063002: Removed permission to do `voidExpression is T` and `.. is! T`. (Closed)

Created:
3 years, 4 months ago by eernst
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed permission to do `voidExpression is T` and `.. is! T`. The informal spec of generalized void used to allow a `typeTest` on an expression of type void. This CL removes that permission, thus leaving only `as` as a narrow escape hatch from void, as decided at the language team meeting on 2017-08-15. R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/8514557c5ada0535f6e5d0e0ae854ed20e79ef6b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M docs/language/informal/generalized-void.md View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
3 years, 4 months ago (2017-08-17 09:14:39 UTC) #2
Lasse Reichstein Nielsen
lgtm
3 years, 4 months ago (2017-08-17 09:28:38 UTC) #3
eernst
3 years, 4 months ago (2017-08-17 09:31:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8514557c5ada0535f6e5d0e0ae854ed20e79ef6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698