Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/analyzer/lib/src/dart/element/element.dart

Issue 3001053002: Re-land "fix #30423, covariant parameter tearoff type should be Object" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 122de77747d5d01faa4d22802c298c7d936616dc..2379185a61a6ce8e5960b94b2c6268af82f45187 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -7225,6 +7225,10 @@ class MethodElementImpl extends ExecutableElementImpl implements MethodElement {
MethodDeclaration computeNode() =>
getNodeMatching((node) => node is MethodDeclaration);
+ // TODO(jmesserly): this implementation is completely wrong:
+ // It does not handle covariant parameters from a generic class.
+ // It drops type parameters from generic methods.
+ // Since this method was for DDC, it should be removed.
@override
FunctionType getReifiedType(DartType objectType) {
// Check whether we have any covariant parameters.
« no previous file with comments | « no previous file | pkg/dev_compiler/lib/src/compiler/code_generator.dart » ('j') | tests/language_2/language_2.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698