Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 3001053002: Re-land "fix #30423, covariant parameter tearoff type should be Object" (Closed)

Created:
3 years, 4 months ago by Jennifer Messerly
Modified:
3 years, 4 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-land "fix #30423, covariant parameter tearoff type should be Object" This is the original CL plus status file fixes. Disables auto-generated function_type tests that are not working for the Dart 2 runtime behavior, and filed #30462 to track. Also removes the separate status that was skipping these tests in DDC when $checked was unset. $checked is not a thing for Dart 2, and DDC test status should never depend on it. This reverts commit 1b0b1a49133f395332106cc6a7883d75947d94e4. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/ed5ced82b1e4947043839c88aa6f55f7aff12ab2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -60 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 6 chunks +30 lines, -12 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/closure.js View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_2/language_2.status View 1 chunk +1 line, -1 line 1 comment Download
M tests/language_2/language_2_dartdevc.status View 1 chunk +66 lines, -0 lines 0 comments Download
M tests/language_strong/covariant_subtyping_test.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M tests/language_strong/function_subtype2_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype3_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_bound_closure3_test.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/language_strong/function_subtype_bound_closure4_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/language_strong/function_subtype_call1_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_call2_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language_strong/function_subtype_cast1_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language_strong/function_subtype_not1_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language_strong/function_type_alias2_test.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/language_strong/language_strong.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
https://codereview.chromium.org/3001053002/diff/1/tests/language_2/language_2.status File tests/language_2/language_2.status (right): https://codereview.chromium.org/3001053002/diff/1/tests/language_2/language_2.status#newcode14 tests/language_2/language_2.status:14: function_type/*: Skip # Needs checked mode. this was how ...
3 years, 4 months ago (2017-08-17 04:11:34 UTC) #3
Leaf
lgtm
3 years, 4 months ago (2017-08-17 05:16:35 UTC) #4
Jennifer Messerly
3 years, 4 months ago (2017-08-17 06:23:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ed5ced82b1e4947043839c88aa6f55f7aff12ab2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698