Issue 300103005: Split StringLiteral from Literal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300103005: Split StringLiteral from Literal. (Closed)

Created:
6 years, 7 months ago by marja

Modified:
6 years, 7 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Split StringLiteral from Literal. This generally makes sense from the user's point of view (they usually need to know or check what kind of Literal they're dealing with; if not, they can just use the virtual value()), and makes the upcoming "make Parser independent of Isolate" work easier (different types of Literals need to be internalized differently). BUG=

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fixes and ports #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : more fixes #

Patch Set 7 : number literals #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+286 lines, -148 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/ast.h	View	1 2 3 4 5 6	7 chunks	+91 lines, -28 lines	0 comments	Download
M	src/ast.cc	View	1 2 3 4 5 6	7 chunks	+26 lines, -14 lines	0 comments	Download
M	src/full-codegen.cc	View	1 2 3 4 5 6	2 chunks	+18 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 2 3 4 5 6	11 chunks	+26 lines, -15 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/parser.cc	View	1 2 3 4 5 6	15 chunks	+25 lines, -21 lines	0 comments	Download
M	src/preparser.h	View		6 chunks	+7 lines, -7 lines	0 comments	Download
M	src/prettyprinter.cc	View	1 2 3 4 5 6	4 chunks	+24 lines, -4 lines	0 comments	Download
M	src/typing.cc	View	1 2 3 4 5 6	3 chunks	+15 lines, -5 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	1 2 3 4 5 6	6 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

rossberg, wdyt? If this looks reasonable to you, I can also split other literal types ...

6 years, 7 months ago (2014-05-26 15:16:03 UTC) #1

Message was sent while issue was closed.

(this turned out to be a side track; closing)

Expand Messages | Collapse Messages