DevTools: allow independent sidebar and viewport resize while in responsive mode.

DevTools: allow independent sidebar and viewport resize while in responsive mode.
drive-by: responsive grid beautified.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174851

[dgozman, 2014-05-26 20:45:29]

lgtm

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/ResponsiveDesignView.js:67:
this._resolutionWidthLabel.classList.toggle("hidden", !this._enabled);
This is unnecessary, as the whole container is detached when disabling.

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/sdk/OverridesSupport.js (right):

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:568:
setTimeout(setDeviceMetricsOverride.bind(this), 100);
I think, we should issue the very first command immediately instead of 100ms
later.

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:685: if
(WebInspector.experimentsSettings.responsiveDesign.isEnabled())
This works bad in undocked. Just use |this.showMetricsRulers()| instead of
|true| below.

[pfeldman, 2014-05-27 07:37:12]

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/ResponsiveDesignView.js (right):

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/ResponsiveDesignView.js:67:
this._resolutionWidthLabel.classList.toggle("hidden", !this._enabled);
On 2014/05/26 20:45:30, dgozman wrote:
> This is unnecessary, as the whole container is detached when disabling.

Done.

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/sdk/OverridesSupport.js (right):

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:568:
setTimeout(setDeviceMetricsOverride.bind(this), 100);
How do I distinguish the first command from the second if I issue it
immediately?

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:685: if
(WebInspector.experimentsSettings.responsiveDesign.isEnabled())
Not sure I follow, no matter what the options are, I don't want to paint neither
viewport size nor the grid when responsive design is on.

[pfeldman, 2014-05-27 07:38:01]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2014-05-27 07:38:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pfeldman@chromium.org/300103004/80001

[dgozman, 2014-05-27 07:55:44]

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
File Source/devtools/front_end/sdk/OverridesSupport.js (right):

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:568:
setTimeout(setDeviceMetricsOverride.bind(this), 100);
On 2014/05/27 07:37:13, pfeldman wrote:
> How do I distinguish the first command from the second if I issue it
> immediately?

You can issue PageAgent call immediately, and clear _setDeviceMetricsTimers and
retry with another call in a timeout.

https://codereview.chromium.org/300103004/diff/60001/Source/devtools/front_en...
Source/devtools/front_end/sdk/OverridesSupport.js:685: if
(WebInspector.experimentsSettings.responsiveDesign.isEnabled())
On 2014/05/27 07:37:13, pfeldman wrote:
> Not sure I follow, no matter what the options are, I don't want to paint
neither
> viewport size nor the grid when responsive design is on.

Responsive deisng is only on in docked mode.

[commit-bot: I haz the power, 2014-05-27 08:55:27]

Change committed as 174851