Issue 300103002: ScriptRegexp::match(): gracefully fail if regexp.exec() throws.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 300103002: ScriptRegexp::match(): gracefully fail if regexp.exec() throws. (Closed)

Created:
6 years, 7 months ago by sof

Modified:
6 years, 7 months ago

Reviewers:
haraken, dcarney

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

ScriptRegexp::match(): gracefully fail if regexp.exec() throws. Check if the internal v8 call to do the actual regexp matching threw an exception and report that as a match failure. R=haraken@chromium.org BUG=377024 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174774

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -0 lines)			Patch
A	LayoutTests/fast/js/regexp-match-exception-no-crash.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/js/regexp-match-exception-no-crash-expected.txt	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/js/script-tests/regexp-match-exception.js	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/bindings/v8/ScriptRegexp.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/300103002/1

6 years, 7 months ago (2014-05-25 18:54:58 UTC) #4

Message was sent while issue was closed.

Change committed as 174774