Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 3001023002: Guard against getting a watch event before the driver is created (issue 30333) (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Guard against getting a watch event before the driver is created R=devoncarew@google.com Committed: https://github.com/dart-lang/sdk/commit/bd8f5ad79fd8186d63e62b96acc59bea869b601c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-16 20:34:53 UTC) #2
Brian Wilkerson
3 years, 4 months ago (2017-08-16 20:35:09 UTC) #3
devoncarew
lgtm
3 years, 4 months ago (2017-08-16 20:47:53 UTC) #4
Brian Wilkerson
3 years, 4 months ago (2017-08-16 21:08:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd8f5ad79fd8186d63e62b96acc59bea869b601c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698