runtime/vm/unit_test.cc - Issue 3001013002: Pass path to platform kernel binary to kernel-service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unit_test.cc

Issue 3001013002: Pass path to platform kernel binary to kernel-service. (Closed)

Patch Set: Fix filenames, add comment regarding null platform_binary Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/unit_test.cc

diff --git a/runtime/vm/unit_test.cc b/runtime/vm/unit_test.cc

index 179e53762c10c5c5551a77b7c4c799bb34c16f91..5490c6118aaec160af52ac4b4454b26bfe723c1f 100644

--- a/runtime/vm/unit_test.cc

+++ b/runtime/vm/unit_test.cc

@@ -191,7 +191,8 @@ char* TestCase::CompileTestScriptWithDFE(const char* url,

bool incrementally) {

Zone* zone = Thread::Current()->zone();

Dart_KernelCompilationResult compilation_result = Dart_CompileSourcesToKernel(

- url, sourcefiles_count, sourcefiles, incrementally);

+ url, NULL /* platform binary can be found at the default location */,

+ sourcefiles_count, sourcefiles, incrementally);

if (compilation_result.status != Dart_KernelCompilationStatus_Ok) {

return OS::SCreate(zone, "Compilation failed %s", compilation_result.error);

« no previous file with comments | « runtime/vm/kernel_isolate.cc ('k') | utils/kernel-service/kernel-service.dart » ('j') | no next file with comments »