Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 3001013002: Pass path to platform kernel binary to kernel-service. (Closed)
Patch Set: Fix filenames, add comment regarding null platform_binary Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/kernel_isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index a868878a7dd42c4c2dc4a1790b6c31e9ba625105..bcf4e0c07b34029ab4aaa63297779ea7634f627b 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -5875,19 +5875,20 @@ DART_EXPORT Dart_Port Dart_KernelPort() {
}
DART_EXPORT Dart_KernelCompilationResult
-Dart_CompileToKernel(const char* script_uri) {
+Dart_CompileToKernel(const char* script_uri, const char* platform_kernel) {
#ifdef DART_PRECOMPILED_RUNTIME
Dart_KernelCompilationResult result;
result.status = Dart_KernelCompilationStatus_Unknown;
result.error = strdup("Dart_CompileToKernel is unsupported.");
return result;
#else
- return KernelIsolate::CompileToKernel(script_uri);
+ return KernelIsolate::CompileToKernel(script_uri, platform_kernel);
#endif
}
DART_EXPORT Dart_KernelCompilationResult
Dart_CompileSourcesToKernel(const char* script_uri,
+ const char* platform_kernel,
int source_files_count,
Dart_SourceFile sources[],
bool incremental_compile) {
@@ -5897,7 +5898,8 @@ Dart_CompileSourcesToKernel(const char* script_uri,
result.error = strdup("Dart_CompileSourcesToKernel is unsupported.");
return result;
#else
- return KernelIsolate::CompileToKernel(script_uri, source_files_count, sources,
+ return KernelIsolate::CompileToKernel(script_uri, platform_kernel,
+ source_files_count, sources,
incremental_compile);
#endif
}
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/kernel_isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698