Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: runtime/bin/dfe.cc

Issue 3001013002: Pass path to platform kernel binary to kernel-service. (Closed)
Patch Set: Fix filenames, add comment regarding null platform_binary Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dfe.cc
diff --git a/runtime/bin/dfe.cc b/runtime/bin/dfe.cc
index 250b60cd9c5e1355b117065133133bf81792ca3e..dad6266e930d7e20d4eed17ce825c4f8299a5989 100644
--- a/runtime/bin/dfe.cc
+++ b/runtime/bin/dfe.cc
@@ -63,7 +63,10 @@ Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
// TODO(asiva): We will have to change this API to pass in a list of files
// that have changed. For now just pass in the main url_string and have it
// recompile the script.
- Dart_KernelCompilationResult kresult = Dart_CompileToKernel(url_string);
+ // TODO(aam): When Frontend is ready, VM should be passing outline.dill
+ // instead of platform.dill to Frontend for compilation.
+ Dart_KernelCompilationResult kresult =
+ Dart_CompileToKernel(url_string, platform_binary_filename_);
if (kresult.status != Dart_KernelCompilationStatus_Ok) {
return Dart_NewApiError(kresult.error);
}
@@ -88,7 +91,10 @@ Dart_Handle DFE::ReloadScript(Dart_Isolate isolate, const char* url_string) {
void* DFE::CompileAndReadScript(const char* script_uri,
char** error,
int* exit_code) {
- Dart_KernelCompilationResult result = Dart_CompileToKernel(script_uri);
+ // TODO(aam): When Frontend is ready, VM should be passing outline.dill
+ // instead of platform.dill to Frontend for compilation.
+ Dart_KernelCompilationResult result =
+ Dart_CompileToKernel(script_uri, platform_binary_filename_);
switch (result.status) {
case Dart_KernelCompilationStatus_Ok:
return Dart_ReadKernelBinary(result.kernel, result.kernel_size);
« no previous file with comments | « no previous file | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698