Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: runtime/vm/isolate_reload_test.cc

Issue 3001013002: Pass path to platform kernel binary to kernel-service. (Closed)
Patch Set: Add TODO to switch to outline.dill Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate_reload_test.cc
diff --git a/runtime/vm/isolate_reload_test.cc b/runtime/vm/isolate_reload_test.cc
index cbe991bd7d588b05383db4fe4f0ec17f8c9d68a7..ef3682dfb7262e315c105df97791022c6e02c657 100644
--- a/runtime/vm/isolate_reload_test.cc
+++ b/runtime/vm/isolate_reload_test.cc
@@ -188,7 +188,7 @@ TEST_CASE(IsolateReload_KernelIncrementalCompileAppAndLib) {
{
void* kernel_pgm = NULL;
char* error = TestCase::CompileTestScriptWithDFE(
- "file:///test-app",
+ "file:///test-app.dart",
siva 2017/08/17 15:40:57 why is the '.dart' suffix needed ?
aam 2017/08/17 16:29:58 Reverted. At some point I was fighting with some w
sizeof(updated_sourcefiles) / sizeof(Dart_SourceFile),
updated_sourcefiles, &kernel_pgm, true /* incrementally */);
EXPECT(error == NULL);
@@ -263,7 +263,7 @@ TEST_CASE(IsolateReload_KernelIncrementalCompileGenerics) {
{
void* kernel_pgm = NULL;
char* error = TestCase::CompileTestScriptWithDFE(
- "file:///test-app",
+ "file:///test-app.dart",
sizeof(updated_sourcefiles) / sizeof(Dart_SourceFile),
updated_sourcefiles, &kernel_pgm, true /* incrementally */);
EXPECT(error == NULL);

Powered by Google App Engine
This is Rietveld 408576698