Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: devil/devil/utils/timeout_retry.py

Issue 3000973002: Make timeout_retry include the total timeout in the exception error (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | devil/devil/utils/watchdog_timer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devil/devil/utils/timeout_retry.py
diff --git a/devil/devil/utils/timeout_retry.py b/devil/devil/utils/timeout_retry.py
index d2304629e9c00a66b114191e2bc5cbb34f52b94a..d01485184da550ddca52758526795a6fbec02edf 100644
--- a/devil/devil/utils/timeout_retry.py
+++ b/devil/devil/utils/timeout_retry.py
@@ -49,7 +49,7 @@ class TimeoutRetryThreadGroup(reraiser_thread.ReraiserThreadGroup):
remaining = self._watcher.GetRemaining()
if remaining is not None and remaining < required:
if msg is None:
- msg = 'Timeout expired'
+ msg = 'Timeout of %.1f secs expired' % self._watcher.GetTimeout()
if remaining > 0:
msg += (', wait of %.1f secs required but only %.1f secs left'
% (required, remaining))
perezju 2017/08/16 08:35:29 As I just wrote on the tracking issue; maybe it's
charliea (OOO until 10-5) 2017/08/18 18:52:18 Done.
« no previous file with comments | « no previous file | devil/devil/utils/watchdog_timer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698