Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 300083003: Changed UI strings for launching an ephemeral app (Closed)

Created:
6 years, 7 months ago by tmdiep
Modified:
6 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changed UI strings for launching an ephemeral app Replace "launch" with "try" for launching ephemeral apps via search results in the app launcher. BUG=377353 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273083

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed the strings after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tmdiep
The launcher results will have "Add" and "Try" buttons. The tooltip says "Launch to try ...
6 years, 7 months ago (2014-05-26 03:49:16 UTC) #1
benwells
https://codereview.chromium.org/300083003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/300083003/diff/1/chrome/app/generated_resources.grd#newcode4132 chrome/app/generated_resources.grd:4132: + Launch to try "<ph name="EXTENSION_NAME">$1<ex>Gmail Checker</ex></ph>"? This feels ...
6 years, 7 months ago (2014-05-27 03:14:34 UTC) #2
tmdiep
On 2014/05/27 03:14:34, benwells wrote: > https://codereview.chromium.org/300083003/diff/1/chrome/app/generated_resources.grd > File chrome/app/generated_resources.grd (right): > > https://codereview.chromium.org/300083003/diff/1/chrome/app/generated_resources.grd#newcode4132 > ...
6 years, 7 months ago (2014-05-27 03:50:05 UTC) #3
benwells
lgtm
6 years, 7 months ago (2014-05-27 05:47:35 UTC) #4
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 7 months ago (2014-05-27 06:05:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/300083003/20001
6 years, 7 months ago (2014-05-27 06:05:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 08:24:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 08:48:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77803)
6 years, 7 months ago (2014-05-27 08:48:35 UTC) #9
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 7 months ago (2014-05-27 23:20:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/300083003/20001
6 years, 7 months ago (2014-05-27 23:21:29 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 00:13:05 UTC) #12
Message was sent while issue was closed.
Change committed as 273083

Powered by Google App Engine
This is Rietveld 408576698