Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 3000823002: Forward Kythe requests to plugins and merge in the results (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Forward Kythe requests to plugins and merge in the results R=jwren@google.com Committed: https://github.com/dart-lang/sdk/commit/8c8969db4c46d5d8bf2e0977dc5fc841ec7fbeaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -15 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 4 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_kythe.dart View 1 chunk +65 lines, -15 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_merger.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-11 19:43:43 UTC) #2
jwren
On 2017/08/11 19:43:43, Brian Wilkerson wrote: LGTM
3 years, 4 months ago (2017-08-11 20:35:06 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-12 15:16:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c8969db4c46d5d8bf2e0977dc5fc841ec7fbeaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698