Issue 3000803003: Revert "[vm] Implement more efficient CAS in simarm/simarm64 modes"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3000803003: Revert "[vm] Implement more efficient CAS in simarm/simarm64 modes" (Closed)

Created:
3 years, 4 months ago by alexmarkov

Modified:
3 years, 4 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org, zra, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "[vm] Implement more efficient CAS in simarm/simarm64 modes" This reverts commit db26c8934799de6205b1c9c9dc498d8fc58a0d07. Committed: https://github.com/dart-lang/sdk/commit/0ffe7148b83fe8e71f44c043b8708994ca59f9a9

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+334 lines, -65 lines)			Patch
M	runtime/vm/atomic.h	View	3 chunks	+25 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_android.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_fuchsia.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_linux.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/atomic_macos.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	runtime/vm/atomic_simulator.h	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.h	View	2 chunks	+34 lines, -7 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	3 chunks	+92 lines, -18 lines	0 comments	Download
M	runtime/vm/simulator_arm64.h	View	3 chunks	+34 lines, -7 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	3 chunks	+109 lines, -33 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (2 generated)

alexmarkov

3 years, 4 months ago (2017-08-12 00:51:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0ffe7148b83fe8e71f44c043b8708994ca59f9a9 (presubmit successful).