Check for null constructor field initializer expression.

Check for null constructor field initializer expression.

When the initializer expression is null, this means that we detected that it was not actually a constant expression.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/2923edc4c0bb7c60a7fe303461e48541e830d278

[Brian Wilkerson, 2017-08-11 14:01:20]

Does this introduce a difference between the element model built from an AST and
the element model built from a summary? If so, that would seem to be a problem.

[scheglov, 2017-08-11 17:34:53]

Description was changed from

==========
Don't include invalid initializers into ConstructorElementImpl.

If we keep such invalid field constructor initializer, it causes an
exception during const evaluation, there was a dump from internal user.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Check for null constructor field initializer expression.

When the initializer expression is null, this means that we detected that it was
not actually a constant expression.

R=brianwilkerson@google.com
BUG=
==========

[scheglov, 2017-08-11 17:38:06]

PTAL

[Brian Wilkerson, 2017-08-11 17:52:44]

lgtm

[scheglov, 2017-08-11 19:35:24]

Description was changed from

==========
Check for null constructor field initializer expression.

When the initializer expression is null, this means that we detected that it was
not actually a constant expression.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Check for null constructor field initializer expression.

When the initializer expression is null, this means that we detected that it was
not actually a constant expression.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/2923edc4c0bb7c60a7fe303461e48541e830d278
==========

[scheglov, 2017-08-11 19:35:25]

Committed patchset #2 (id:20001) manually as
2923edc4c0bb7c60a7fe303461e48541e830d278 (presubmit successful).