Issue 3000723002: Extract BytesMemoryCache from MemoryCachingByteStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3000723002: Extract BytesMemoryCache from MemoryCachingByteStore. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Extract BytesMemoryCache from MemoryCachingByteStore. BytesMemoryCache will be used in Bazel workers to cache values of inputs by their digest, so avoid reading the same files multiple times. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/eb3c3d8f77437802bfd7377d0accc6dc0c9370a2

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -44 lines)			Patch
	M	pkg/front_end/lib/src/byte_store/byte_store.dart	View		2 chunks	+54 lines, -36 lines	0 comments	Download
	M	pkg/front_end/test/src/byte_store/byte_store_test.dart	View		7 chunks	+87 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

3 years, 4 months ago (2017-08-11 19:25:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eb3c3d8f77437802bfd7377d0accc6dc0c9370a2 (presubmit successful).