Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 300063014: linux_aura: Update Debian packaging to Depend: on libappindicator1. (Closed)

Created:
6 years, 7 months ago by Elliot Glaysher
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Update Debian packaging to Depend: on libappindicator1. BUG=374686 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273158

Patch Set 1 #

Total comments: 1

Patch Set 2 : alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/installer/linux/debian/build.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Elliot Glaysher
Is this where additional packages should go?
6 years, 7 months ago (2014-05-27 23:22:19 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/300063014/diff/1/chrome/installer/linux/debian/build.sh File chrome/installer/linux/debian/build.sh (right): https://codereview.chromium.org/300063014/diff/1/chrome/installer/linux/debian/build.sh#newcode293 chrome/installer/linux/debian/build.sh:293: lsb-base (>=3.2), xdg-utils (>= 1.0.2), wget, libappindicator1" alphabetical ...
6 years, 7 months ago (2014-05-28 00:45:10 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 7 months ago (2014-05-28 00:56:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/300063014/20001
6 years, 7 months ago (2014-05-28 00:57:39 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 05:37:04 UTC) #5
Message was sent while issue was closed.
Change committed as 273158

Powered by Google App Engine
This is Rietveld 408576698