Make async methods UpdateLock() and ResetLock() in MockScreenOrientationController.

Make async methods UpdateLock() and ResetLock() in MockScreenOrientationController.

BUG=162827
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273306

[ostap, 2014-05-27 22:20:26]

Fix for this: https://codereview.chromium.org/302703003/

[Inactive, 2014-05-28 11:49:38]

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
File content/renderer/screen_orientation/mock_screen_orientation_controller.cc
(right):

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.cc:37:
LOG(ERROR) << "MockScreenOrientationController::UpdateLock()";
I think you meant to remove this logging?

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.cc:44:
LOG(ERROR) << "MockScreenOrientationController::UpdateLockSync()";
ditto.

[mlamouri (slow - plz ping), 2014-05-28 13:23:24]

Thanks for this patch! :)

LGTM with Chris comments applied and mine.

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
File content/renderer/screen_orientation/mock_screen_orientation_controller.h
(right):

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.h:33:
~MockScreenOrientationController() { }
Please, make the dtor virtual, remove the comment and move the definition to the
cc file.

[ostap, 2014-05-28 14:38:15]

The CQ bit was checked by sl.ostapenko@samsung.com

[commit-bot: I haz the power, 2014-05-28 14:38:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/300063012/60001

[ostap, 2014-05-28 14:40:21]

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
File content/renderer/screen_orientation/mock_screen_orientation_controller.cc
(right):

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.cc:37:
LOG(ERROR) << "MockScreenOrientationController::UpdateLock()";
On 2014/05/28 11:49:39, Chris Dumez wrote:
> I think you meant to remove this logging?

Done.

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.cc:44:
LOG(ERROR) << "MockScreenOrientationController::UpdateLockSync()";
On 2014/05/28 11:49:39, Chris Dumez wrote:
> ditto.

Done.

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
File content/renderer/screen_orientation/mock_screen_orientation_controller.h
(right):

https://codereview.chromium.org/300063012/diff/20001/content/renderer/screen_...
content/renderer/screen_orientation/mock_screen_orientation_controller.h:33:
~MockScreenOrientationController() { }
On 2014/05/28 13:23:24, Mounir Lamouri wrote:
> Please, make the dtor virtual, remove the comment and move the definition to
the
> cc file.

Done.

[commit-bot: I haz the power, 2014-05-28 16:31:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)

[commit-bot: I haz the power, 2014-05-28 18:56:43]

Change committed as 273306