Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 300063009: Hide the deletion confirmation overlay when the page state changes. (Closed)

Created:
6 years, 7 months ago by davidben
Modified:
6 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Hide the deletion confirmation overlay when the page state changes. BUG=377386 TEST=See bug, comment #2. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/history/history.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
Splitting this out from the uber.js fix since it's fairly orthogonal and this'll make it ...
6 years, 7 months ago (2014-05-27 17:50:08 UTC) #1
Dan Beam
lgtm
6 years, 7 months ago (2014-05-27 18:04:44 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-05-27 19:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/300063009/1
6 years, 7 months ago (2014-05-27 19:11:26 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 21:24:58 UTC) #5
Message was sent while issue was closed.
Change committed as 273037

Powered by Google App Engine
This is Rietveld 408576698