Add new flag for consistent identity.

Add new flag for consistent identity.
Once this CL is committed, we need to change the server side config to include
new trial types and remove the expid.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273792

[Roger Tawa OOO till Jul 10th, 2014-05-28 03:08:44]

Hi Hui,

Please take a look.  This just introduces the new flag, but its not used yet. 
Thanks.

[guohui, 2014-05-28 18:27:22]

https://codereview.chromium.org/300063005/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/300063005/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:13418: <message
name="IDS_FLAGS_ENABLE_CONSISTENT_IDENTITY_NAME" desc="Title for the flag to
enable the new profile management.">
nits: we have already agreed with gaia to use the name
'enable_account_consistency', while i actually like this name better, i think we
should be consistent. And this applies to every name containing
"consistent_identity" in other files.

https://codereview.chromium.org/300063005/diff/40001/components/signin/core/c...
File components/signin/core/common/profile_management_switches.cc (right):

https://codereview.chromium.org/300063005/diff/40001/components/signin/core/c...
components/signin/core/common/profile_management_switches.cc:66: bool
CheckFlag(std::string command_switch, State max_state, bool active_state) {
as discussed offline, this should be the min_state instead, and at line 74 it
should check state >= min_state. Otherwise when consistent identity is on, all
new profile management features would be turned off.

[Roger Tawa OOO till Jul 10th, 2014-05-29 01:23:12]

Thanks Hui, please take another look.

https://codereview.chromium.org/300063005/diff/40001/chrome/app/generated_res...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/300063005/diff/40001/chrome/app/generated_res...
chrome/app/generated_resources.grd:13418: <message
name="IDS_FLAGS_ENABLE_CONSISTENT_IDENTITY_NAME" desc="Title for the flag to
enable the new profile management.">
On 2014/05/28 18:27:23, guohui wrote:
> nits: we have already agreed with gaia to use the name
> 'enable_account_consistency', while i actually like this name better, i think
we
> should be consistent. And this applies to every name containing
> "consistent_identity" in other files.

Done.

https://codereview.chromium.org/300063005/diff/40001/components/signin/core/c...
File components/signin/core/common/profile_management_switches.cc (right):

https://codereview.chromium.org/300063005/diff/40001/components/signin/core/c...
components/signin/core/common/profile_management_switches.cc:66: bool
CheckFlag(std::string command_switch, State max_state, bool active_state) {
On 2014/05/28 18:27:23, guohui wrote:
> as discussed offline, this should be the min_state instead, and at line 74 it
> should check state >= min_state. Otherwise when consistent identity is on, all
> new profile management features would be turned off.

Yeah, not sure how I reversed the condition.  At the same time I simplified this
function by removing active_state arg.  This was only needed to handle
IsEnableWebBasedSignin() which is a slightly special case. but instead handled
it there.

[guohui, 2014-05-29 21:50:50]

lgtm

[Roger Tawa OOO till Jul 10th, 2014-05-30 02:54:39]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-30 02:56:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/300063005/120001

[commit-bot: I haz the power, 2014-05-30 07:04:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-30 10:35:05]

Change committed as 273792

[Evan Stade, 2015-08-12 19:03:51]

On 2014/05/30 10:35:05, commit-bot: I haz the power wrote:
> Change committed as 273792

what is the state of the account consistency flag/field trial? I'm updating some
UI; do we need to continue to support this flag?

[Roger Tawa OOO till Jul 10th, 2015-08-13 11:44:37]

On 2015/08/12 19:03:51, Evan Stade wrote:
> On 2014/05/30 10:35:05, commit-bot: I haz the power wrote:
> > Change committed as 273792
> 
> what is the state of the account consistency flag/field trial? I'm updating
some
> UI; do we need to continue to support this flag?

Yes. Account consistency is enabled by default on mobile platforms but still
under the flag on desktop and cros.