Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 3000543002: Migrate test block 11 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, Bob Nystrom
CC:
dart2now-team_google.com, reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 11 to Dart 2.0. Interesting items in this block: - Manually merged iterable_generate_test changes from both trees and dropped some typeAssertionsEnabled/checked mode checking. BUG= R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/e89d0d2e1445b16cb8c071be69a6f19fbc2162f4

Patch Set 1 #

Patch Set 2 : Removed checkedMode check. #

Total comments: 1

Patch Set 3 : Fix merge problems and update test status with head changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2030 lines) Patch
M tests/corelib/corelib.status View 1 2 5 chunks +1 line, -33 lines 0 comments Download
D tests/corelib/iterable_generate_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/corelib/iterable_join_test.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D tests/corelib/iterable_last_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib/iterable_last_where_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/corelib/iterable_length_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib/iterable_mapping_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib/iterable_reduce_test.dart View 1 chunk +0 lines, -205 lines 0 comments Download
D tests/corelib/iterable_return_type_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/corelib/iterable_single_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/iterable_single_where_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib/iterable_skip_test.dart View 1 chunk +0 lines, -258 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 2 9 chunks +39 lines, -0 lines 0 comments Download
A + tests/corelib_2/iterable_generate_test.dart View 1 2 chunks +2 lines, -9 lines 0 comments Download
A + tests/corelib_2/iterable_join_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_last_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_last_where_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_length_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_mapping_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/corelib_2/iterable_reduce_test.dart View 1 2 5 chunks +16 lines, -16 lines 0 comments Download
A + tests/corelib_2/iterable_return_type_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_single_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_single_where_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/iterable_skip_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 chunk +0 lines, -4 lines 0 comments Download
D tests/corelib_strong/iterable_generate_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/corelib_strong/iterable_join_test.dart View 1 chunk +0 lines, -148 lines 0 comments Download
D tests/corelib_strong/iterable_last_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/corelib_strong/iterable_last_where_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/corelib_strong/iterable_length_test.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/corelib_strong/iterable_mapping_test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/corelib_strong/iterable_reduce_test.dart View 1 chunk +0 lines, -205 lines 0 comments Download
D tests/corelib_strong/iterable_return_type_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/corelib_strong/iterable_single_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/iterable_single_where_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib_strong/iterable_skip_test.dart View 1 chunk +0 lines, -257 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jcollins
3 years, 4 months ago (2017-08-08 18:28:47 UTC) #2
bkonyi
Remove the [ $strong ] entry in the status file and rerun the tests. If ...
3 years, 4 months ago (2017-08-09 16:27:43 UTC) #3
jcollins
3 years, 4 months ago (2017-08-16 16:16:46 UTC) #5
jcollins
iterable_mapping_test and iterable_reduce_test had to be updated with recent changes to runtimes/compilers. On 2017/08/16 16:16:46, ...
3 years, 4 months ago (2017-08-16 16:45:06 UTC) #6
bkonyi
Merge changes LGTM
3 years, 4 months ago (2017-08-16 17:11:26 UTC) #7
jcollins
3 years, 4 months ago (2017-08-16 17:16:51 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e89d0d2e1445b16cb8c071be69a6f19fbc2162f4.

Powered by Google App Engine
This is Rietveld 408576698