Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3000423002: Update tests status to make (fyi) dartkp buildbots green. (Closed)

Created:
3 years, 4 months ago by aam
Modified:
3 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, alexmarkov
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Wholesale update tests status in attempt to make (fyi) dartkp buildbots green. Buildbots are here: https://build.chromium.org/p/client.dart.fyi/console. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/7cbb96c199247374122288d186b77b1b87678a3d

Patch Set 1 #

Patch Set 2 : Update file_system_watcher_test status #

Patch Set 3 : Remove dartk+vm section since it can't happen #

Patch Set 4 : Refresh status #

Patch Set 5 : Update statuses #

Total comments: 2

Patch Set 6 : Skip mirrors tests under dartkp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -17 lines) Patch
M runtime/tests/vm/vm.status View 1 2 3 1 chunk +1 line, -9 lines 0 comments Download
M samples/samples.status View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 3 4 3 chunks +22 lines, -3 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 4 5 1 chunk +25 lines, -4 lines 0 comments Download
M tests/language_2/language_2_kernel.status View 1 2 3 2 chunks +24 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
aam
3 years, 4 months ago (2017-08-23 21:45:40 UTC) #4
aam
3 years, 4 months ago (2017-08-23 21:45:41 UTC) #5
siva
lgtm https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status#newcode557 tests/lib/lib.status:557: [ $compiler == dartkp ] mirrors is not ...
3 years, 3 months ago (2017-08-28 23:38:28 UTC) #6
aam
https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status#newcode557 tests/lib/lib.status:557: [ $compiler == dartkp ] On 2017/08/28 23:38:28, siva ...
3 years, 3 months ago (2017-08-29 00:13:16 UTC) #7
aam
https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/3000423002/diff/80001/tests/lib/lib.status#newcode557 tests/lib/lib.status:557: [ $compiler == dartkp ] On 2017/08/28 23:38:28, siva ...
3 years, 3 months ago (2017-08-29 00:13:16 UTC) #8
aam
3 years, 3 months ago (2017-08-29 01:32:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
7cbb96c199247374122288d186b77b1b87678a3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698