Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart

Issue 3000353002: Start implementing logic for determining when formal parameters need type checks. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
index 7e8fd9126f660acd977adb6a42eccf29accfacc3..3bf38a3d50aeb30d091fea8021c7085ef731e5e5 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart
@@ -2378,6 +2378,17 @@ class KernelVariableDeclaration extends VariableDeclaration
final bool _isLocalFunction;
+ /// If this variable declaration represents a formal parameter, indicates
+ /// whether uses of it need to be type-checked due to the covariance of class
+ /// type parameters.
+ ///
+ /// TODO(paulberry): replace this with an enum so that it can represent
+ /// "unsafe" parameters as well.
+ ///
+ /// TODO(paulberry): remove this once there is a corresponding annotation in
+ /// the kernel representation.
+ bool isSemiSafe = false;
ahe 2017/08/23 09:55:58 As for the future direction, I suggest these are r
Paul Berry 2017/08/23 17:09:10 Let's talk with the kernel folks about this. My g
+
KernelVariableDeclaration(String name, this._functionNestingLevel,
{Expression initializer,
DartType type,

Powered by Google App Engine
This is Rietveld 408576698