Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(326)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: pkg/kernel/testcases/closures/loop2.dart
Issue
3000333002
:
Fix several bugs in closure conversion. (Closed)
Patch Set:
Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
pkg/kernel/lib/ast.dart
pkg/kernel/lib/transformations/closure/converter.dart
pkg/kernel/lib/transformations/closure/invalidate_closures.dart
pkg/kernel/testcases/arity.dart
pkg/kernel/testcases/closures/blocks.dart
pkg/kernel/testcases/closures/blocks.dart.expect
pkg/kernel/testcases/closures/for_in_closure.dart
pkg/kernel/testcases/closures/for_in_closure.dart.expect
pkg/kernel/testcases/closures/loop2.dart
pkg/kernel/testcases/closures/loop2.dart.expect
pkg/kernel/testcases/closures/syncstar.dart
pkg/kernel/testcases/closures/syncstar.dart.expect
runtime/vm/flow_graph_compiler_arm.cc
runtime/vm/flow_graph_compiler_arm64.cc
runtime/vm/flow_graph_compiler_ia32.cc
runtime/vm/flow_graph_compiler_x64.cc
runtime/vm/kernel_binary_flowgraph.cc
View unified diff
|
Download patch
« pkg/kernel/testcases/closures/blocks.dart
('K') |
« pkg/kernel/testcases/closures/for_in_closure.dart.expect
('k') |
pkg/kernel/testcases/closures/loop2.dart.expect »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
/*
2
* Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
3
* for details. All rights reserved. Use of this source code is governed by a
4
* BSD-style license that can be found in the LICENSE file.
5
*/
6
void doit(int x) {
7
final int max = 10;
8
final double expectedSum = ((max - 1) * max) / 2;
9
10
int counter = 0;
11
var calls = [];
12
while (counter < max) {
13
int pos = counter;
14
calls.add(() => pos + x);
15
counter++;
16
}
17
18
double sum = 0.0;
19
for (var c in calls) sum += c();
20
if (sum != expectedSum)
21
throw new Exception("Unexpected sum = $sum != $expectedSum");
22
}
23
24
void main() {
25
doit(0);
26
}
OLD
NEW
« pkg/kernel/testcases/closures/blocks.dart
('K') |
« pkg/kernel/testcases/closures/for_in_closure.dart.expect
('k') |
pkg/kernel/testcases/closures/loop2.dart.expect »
('j') |
no next file with comments »
Issue 3000333002: Fix several bugs in closure conversion. (Closed)
Created 3 years, 4 months ago by sjindel
Modified 3 years, 4 months ago
Reviewers: Dmitry Stefantsov, Karl Klose
Base URL:
Comments: 28
This is Rietveld
408576698