Settings: load iframes anew when switching to a non-current one.

Settings: load iframes anew when switching to a non-current one.

Some pages may have state not reflected in the URL, such as the history page's
modal dialog. If the reuse the frame, when going back away from the history
page and forward to it again, the modal dialog stays there. To match what would
happen were the history page the top-level, load the page anew if not the
current.

This reverts the changePage/selectPage split from r271538 since it's no longer
needed.

BUG=377386
TEST=See bug, initial report.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273162

[davidben, 2014-05-27 17:52:31]

This seems the cleanest in terms of making uber.js behave as close as possible
to how it would were the iframes top-level.

(Arguably, since we never switch iframes without reloading them, we shouldn't
even keep the non-current frames around...)

[Dan Beam, 2014-05-27 18:01:15]

lgtm

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:110: // history page's "Remove selected
items" overlay. https://crbug.com/377386
https://crbug -> http://crbug to fix 80 col (and so the link works)

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:326: var lastSelected =
document.querySelector('.iframe-container.selected');
lower to right before use

[davidben, 2014-05-27 19:18:35]

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:110: // history page's "Remove selected
items" overlay. https://crbug.com/377386
On 2014/05/27 18:01:16, Dan Beam wrote:
> https://crbug -> http://crbug to fix 80 col (and so the link works)

Done. (https://crbug.com works now, actually.)

https://codereview.chromium.org/300033009/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:326: var lastSelected =
document.querySelector('.iframe-container.selected');
On 2014/05/27 18:01:16, Dan Beam wrote:
> lower to right before use

Done.

[davidben, 2014-05-27 19:19:04]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:20:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/300033009/20001

[commit-bot: I haz the power, 2014-05-27 22:25:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 05:45:09]

Change committed as 273162