editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java - Issue 300033008: Remember propagated types for PropertyInducingElement(s).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

Issue 300033008: Remember propagated types for PropertyInducingElement(s). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/member/Member.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/StaticTypeAnalyzer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

index 9f5b1c3ad742298f2290d53718abf20252ffd072..bf0165ff1d9bf93b540edd4f8c1fa34553fd33e6 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java

@@ -83,6 +83,7 @@ import com.google.dart.engine.element.ParameterElement;

import com.google.dart.engine.element.PropertyInducingElement;

import com.google.dart.engine.element.VariableElement;

import com.google.dart.engine.error.AnalysisErrorListener;

+import com.google.dart.engine.internal.element.PropertyInducingElementImpl;

import com.google.dart.engine.internal.element.VariableElementImpl;

import com.google.dart.engine.internal.scope.Scope;

import com.google.dart.engine.scanner.TokenType;

@@ -1005,14 +1006,15 @@ public class ResolverVisitor extends ScopedVisitor {

if (potentialType == null || potentialType.isBottom()) {

return;

}

- if (element instanceof PropertyInducingElement) {

- PropertyInducingElement variable = (PropertyInducingElement) element;

- if (!variable.isConst() && !variable.isFinal()) {

- return;

- }

Type currentType = getBestType(element);

if (currentType == null || !currentType.isMoreSpecificThan(potentialType)) {

+ if (element instanceof PropertyInducingElement) {

+ PropertyInducingElement variable = (PropertyInducingElement) element;

+ if (!variable.isConst() && !variable.isFinal()) {

+ return;

+ }

+ ((PropertyInducingElementImpl) variable).setPropagatedType(potentialType);

+ }

overrideManager.setType(element, potentialType);

}