Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 300033: Merge 29607 - Revert r29418 as it caused a regression.... (Closed)

Created:
11 years, 2 months ago by jon
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 29607 - Revert r29418 as it caused a regression. OnKillFocus() is being called during destruction, and tries to access a render_widget_host_ which has already been NULLed. BUG=25290, 24248 TBR=jcampan Review URL: http://codereview.chromium.org/308014 TBR=eroman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
MM chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jon
11 years, 2 months ago (2009-10-21 06:14:38 UTC) #1
eroman
11 years, 2 months ago (2009-10-21 17:16:21 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698