Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 300023011: Convert String array index/length hash to BitField (Closed)

Created:
6 years, 7 months ago by danno
Modified:
6 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Convert String array index/length hash to BitField R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21533

Patch Set 1 #

Patch Set 2 : Add ports #

Patch Set 3 : More tweaks #

Patch Set 4 : More port stuff #

Patch Set 5 : Fix x64 #

Patch Set 6 : Fix ARM #

Patch Set 7 : Don't clobber hash #

Patch Set 8 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -44 lines) Patch
M src/arm/macro-assembler-arm.h View 1 2 3 4 5 6 7 1 chunk +21 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 5 6 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 1 chunk +18 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 1 chunk +1 line, -7 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 6 7 1 chunk +9 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
6 years, 7 months ago (2014-05-27 13:45:54 UTC) #1
Toon Verwaest
lgtm with comment: please always move hash to index before decoding to avoid destroying hash ...
6 years, 7 months ago (2014-05-27 14:06:22 UTC) #2
danno
6 years, 7 months ago (2014-05-27 14:55:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #8 manually as r21533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698