Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 300023008: [fsp] Rename chrome://fsp-internals to chrome://provided-file-systems. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto
Visibility:
Public.

Description

[fsp] Rename chrome://fsp-internals to chrome://provided-file-systems. This patch renames the cryptic fsp name to easier to understand provided "file systems" in the C++ code. Also, the url has changed accordingly. TEST=Tested manually by invoking chrome://provided-file-systems with a running providing extension. BUG=376095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -305 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/resources/chromeos/fsp_internals.css View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/resources/chromeos/fsp_internals.html View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/resources/chromeos/fsp_internals.js View 1 chunk +0 lines, -39 lines 0 comments Download
A + chrome/browser/resources/chromeos/provided_file_systems.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/chromeos/provided_file_systems.html View 1 chunk +5 lines, -4 lines 0 comments Download
A + chrome/browser/resources/chromeos/provided_file_systems.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 5 chunks +5 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/fsp_internals_ui.h View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/chromeos/fsp_internals_ui.cc View 1 chunk +0 lines, -123 lines 0 comments Download
A chrome/browser/ui/webui/chromeos/provided_file_systems_ui.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/provided_file_systems_ui.cc View 4 chunks +23 lines, -19 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@jochen: PTAL. This is a mechanical change, renaming the cryptic "fsp" to "provided file systems". ...
6 years, 7 months ago (2014-05-27 05:34:30 UTC) #1
jochen (gone - plz use gerrit)
rs lgtm
6 years, 7 months ago (2014-05-27 13:45:47 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 23:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/300023008/1
6 years, 7 months ago (2014-05-27 23:23:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 7 months ago (2014-05-28 02:28:13 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 03:35:27 UTC) #6
Message was sent while issue was closed.
Change committed as 273145

Powered by Google App Engine
This is Rietveld 408576698