pkg/shelf - send Date header in shelf_io

pkg/shelf/test/shelf_io_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library shelf_io_test;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:http/http.dart' as http;
+import 'package:http_parser/http_parser.dart' as parser;
 import 'package:scheduled_test/scheduled_test.dart';
 import 'package:shelf/shelf.dart';
 import 'package:shelf/shelf_io.dart' as shelf_io;
 
 import 'test_util.dart';
 
 void main() {
   test('sync handler returns a value to the client', () {
     _scheduleServer(syncHandler);
 
@@ skipping 220 matching lines @@
         return syncHandler(request);
       }, 'localhost', 0).then((server) {
         return http.get('http://localhost:${server.port}').then((response) {
           expect(response.statusCode, HttpStatus.OK);
           expect(response.body, 'Hello from /');
           server.close();
         });
       });
     });
   });
+
+  group('date header', () {
+    test('is sent by default', () {
+      _scheduleServer(syncHandler);
+
+      return _scheduleGet().then((response) {
+        expect(response.headers, contains('date'));
+        var responseDate = parser.parseHttpDate(response.headers['date']);
+
+        var nowEpoch = new DateTime.now().toUtc().millisecondsSinceEpoch;
+        expect(responseDate.millisecondsSinceEpoch,
+            inInclusiveRange(nowEpoch - 1000, nowEpoch));

[nweiz, 2014/05/27 19:52:44]

This is potentially flaky. Instead of assuming the time will be within 1000ms,
record the time before the GET and use that as the range.

[kevmoo, 2014/05/27 20:50:58]

Done. I have to add in some rounding to account for HTTP date dropping
milliseconds.

+      });
+    });
+
+    test('defers to header in response', () {
+      var date = new DateTime.utc(1981, 6, 5);
+      _scheduleServer((request) {
+        return new Response.ok('test', headers: {
+          HttpHeaders.DATE: parser.formatHttpDate(date)

[nweiz, 2014/05/27 19:52:44]

Nit: I don't like using HttpHeaders over just a header string.

[kevmoo, 2014/05/27 20:50:58]

We're already using it in shelf_io. Eh...

+        });
+      });
+
+      return _scheduleGet().then((response) {
+        expect(response.headers, contains('date'));
+        var responseDate = parser.parseHttpDate(response.headers['date']);
+        expect(responseDate, date);
+      });
+    });
+  });
 }
 
 int _serverPort;
 
 Future _scheduleServer(Handler handler) {
   return schedule(() => shelf_io.serve(handler, 'localhost', 0).then((server) {
     currentSchedule.onComplete.schedule(() {
       _serverPort = null;
       return server.close(force: true);
     });
@@ skipping 16 matching lines @@
 
     var request = new http.Request('POST',
         Uri.parse('http://localhost:$_serverPort/'));
 
     if (headers != null) request.headers.addAll(headers);
     if (body != null) request.body = body;
 
     return request.send();
   });
 }