Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 300005: Correctly handle extension reloading in the task manager.... (Closed)

Created:
11 years, 2 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Correctly handle extension reloading in the task manager. BUG=18693 TEST=Added new tests to browser_tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
M chrome/browser/extensions/extension_browsertest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/task_manager.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/task_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/task_manager_browsertest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/task_manager_resource_providers.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 5 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Please review: aa: extension parts jcampan: mostly FYI, but you may want to look at ...
11 years, 2 months ago (2009-10-19 15:42:10 UTC) #1
Erik does not do reviews
LGTM
11 years, 2 months ago (2009-10-19 16:22:50 UTC) #2
Aaron Boodman
11 years, 2 months ago (2009-10-19 19:52:48 UTC) #3
I defer to erikkay

Powered by Google App Engine
This is Rietveld 408576698