X64 Win64: Reimplement fmod so that it works.

src/x64/macro-assembler-x64.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1295 matching lines @@
 void MacroAssembler::Push(Smi* source) {
   intptr_t smi = reinterpret_cast<intptr_t>(source);
   if (is_int32(smi)) {
     push(Immediate(static_cast<int32_t>(smi)));
   } else {
     Set(kScratchRegister, smi);
     push(kScratchRegister);
   }
 }
 
 

[William Hesse, 2009/10/20 14:50:51]

Can this load optimization, and the Operand + displacement constructor, be moved
out to a separate changelist?  That way we can see if it is worth it.

[Lasse Reichstein, 2009/10/22 11:22:53]

I'm dropping this approach, going for a replacement of fmod at the C++ level
instead, but I'll save this change and see if it makes sense on its own.

+void MacroAssembler::FLoadSmi(const Operand& src) {
+  fild_s(Operand(src, kIntSize));
+}
+
+
 void MacroAssembler::Test(const Operand& src, Smi* source) {
   intptr_t smi = reinterpret_cast<intptr_t>(source);
   if (is_int32(smi)) {
     testl(src, Immediate(static_cast<int32_t>(smi)));
   } else {
     Move(kScratchRegister, source);
     testq(src, kScratchRegister);
   }
 }
 
@@ skipping 898 matching lines @@
 CodePatcher::~CodePatcher() {
   // Indicate that code has changed.
   CPU::FlushICache(address_, size_);
 
   // Check that the code was patched as expected.
   ASSERT(masm_.pc_ == address_ + size_);
   ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
 }
 
 } }  // namespace v8::internal