Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 300003002: Use the win32 device scale factor in Chrome ASH on Windows. (Closed)

Created:
6 years, 7 months ago by ananta
Modified:
6 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Visibility:
Public.

Description

Use the win32 device scale factor in Chrome ASH on Windows. The WinRT interfaces seem to be giving us the wrong values in metro mode. On Windows 8 the IDisplayProperties interface always gives us 100% for the scale factor and a dpi of 96. On 8.1 it reports incorrect scale factors which cause the content to be displayed shrunk. Fix is to use the win32 scale factor in ASH and convert the input coordinates to DIP correctly before passing them to chrome. We also convert the width and height of the window to pixels using the win32 scale factor before initializing the direct3d swap chain. BUG=376529 R=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273605

Patch Set 1 #

Patch Set 2 : Removed include #

Total comments: 2

Patch Set 3 : Presubmit warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -23 lines) Patch
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +5 lines, -2 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 12 chunks +40 lines, -12 lines 0 comments Download
M win8/metro_driver/direct3d_helper.cc View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
M win8/metro_driver/metro_driver.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
ananta
6 years, 7 months ago (2014-05-24 02:40:49 UTC) #1
cpu_(ooo_6.6-7.5)
looks good but I still want to understand why we need both scales. I'll find ...
6 years, 7 months ago (2014-05-27 21:56:27 UTC) #2
ananta
https://codereview.chromium.org/300003002/diff/20001/win8/metro_driver/chrome_app_view_ash.cc File win8/metro_driver/chrome_app_view_ash.cc (right): https://codereview.chromium.org/300003002/diff/20001/win8/metro_driver/chrome_app_view_ash.cc#newcode408 win8/metro_driver/chrome_app_view_ash.cc:408: // via the win32 scale factor which achieves the ...
6 years, 7 months ago (2014-05-27 22:46:16 UTC) #3
cpu_(ooo_6.6-7.5)
I get it now, the input coordinates are scaled with metro strange values. lgtm.
6 years, 6 months ago (2014-05-28 23:06:10 UTC) #4
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 6 months ago (2014-05-29 00:50:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/300003002/20001
6 years, 6 months ago (2014-05-29 00:50:41 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 02:26:29 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 02:33:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/70315)
6 years, 6 months ago (2014-05-29 02:33:49 UTC) #9
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 6 months ago (2014-05-29 18:46:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/300003002/40001
6 years, 6 months ago (2014-05-29 18:48:13 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 20:34:53 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 21:34:06 UTC) #13
Message was sent while issue was closed.
Change committed as 273605

Powered by Google App Engine
This is Rietveld 408576698