pkg/kernel/lib/binary/ast_from_binary.dart - Issue 3000023002: [kernel] Add fileOffset on FunctionExpression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 3000023002: [kernel] Add fileOffset on FunctionExpression (Closed)

Patch Set: Almost forgot the C++ side of things Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/binary/ast_from_binary.dart

diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart

index 336633446a84793fbdaeec611bfb06c7ea46cd79..c4ab123429073d0e8a0a6b3f5f6e81d018ed7d26 100644

--- a/pkg/kernel/lib/binary/ast_from_binary.dart

+++ b/pkg/kernel/lib/binary/ast_from_binary.dart

@@ -926,7 +926,8 @@ class BinaryBuilder {

case Tag.AwaitExpression:

return new AwaitExpression(readExpression());

case Tag.FunctionExpression:

- return new FunctionExpression(readFunctionNode());

+ int offset = readOffset();

+ return new FunctionExpression(readFunctionNode())..fileOffset = offset;

case Tag.Let:

var variable = readVariableDeclaration();

int stackHeight = variableStack.length;

« no previous file with comments | « pkg/kernel/binary.md ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »