Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 3000023002: [kernel] Add fileOffset on FunctionExpression (Closed)

Created:
3 years, 4 months ago by jensj
Modified:
3 years, 4 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Almost forgot the C++ side of things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pkg/kernel/binary.md View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 4 months ago (2017-08-16 10:03:04 UTC) #2
Johnni Winther
lgtm
3 years, 4 months ago (2017-08-16 10:06:23 UTC) #3
jensj
3 years, 4 months ago (2017-08-16 10:10:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3f9d99be50ce783ab71fca61bdb462729104e478 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698