call _getImports only once: on a large app this was about 5s extra.

call _getImports only once: on a large app this was about 5s extra.

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/10dce08aedceffa27642b174b6df38afcbe8e105

[Siggi Cherem (dart-lang), 2017-08-16 00:25:31]

Patchset #2 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-08-16 00:25:36]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-08-16 00:26:51]

sigmund@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-08-16 01:09:22]

lgtm

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:547: Iterable<ImportElement> imports =
_getImports(dependency, library);
Presumably this is actually a List.

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:548: bool isExplicitlyDeferred =
This can still be a function, just taking the iterable instead.
That gives somewhere nicer for the comments to live and avoids needing to
understand !x && y

[Siggi Cherem (dart-lang), 2017-08-16 01:18:05]

Patchset #2 (id:50001) has been deleted

[Siggi Cherem (dart-lang), 2017-08-16 01:18:20]

thanks

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:547: Iterable<ImportElement> imports =
_getImports(dependency, library);
On 2017/08/16 01:09:22, sra1 wrote:
> Presumably this is actually a List.

Ack - I'm using the declared type for now. I feel we would have to update that
in the element model too if we wanted to use it as List here.

https://codereview.chromium.org/3000003002/diff/30002/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:548: bool isExplicitlyDeferred =
On 2017/08/16 01:09:22, sra1 wrote:
> This can still be a function, just taking the iterable instead.
> That gives somewhere nicer for the comments to live and avoids needing to
> understand !x && y

Done. Moved it was it used to be, but made the list of imports an argument
instead.

[sra1, 2017-08-16 01:45:50]

lgtm

[Siggi Cherem (dart-lang), 2017-08-16 03:27:35]

Description was changed from

==========
call _getImports only once: on a large app this was about 5s extra.

BUG=
==========

to

==========
call _getImports only once: on a large app this was about 5s extra.

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/10dce08aedceffa27642b174b6df38afcbe8e105
==========

[Siggi Cherem (dart-lang), 2017-08-16 03:27:36]

Committed patchset #2 (id:70001) manually as
10dce08aedceffa27642b174b6df38afcbe8e105 (presubmit successful).