Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2999833002: [VM logging] Fix nesting of log blocker (second attempt). (Closed)

Created:
3 years, 4 months ago by regis
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM logging] Fix nesting of log blocker (second attempt). Fix expectations of log blocker test, i.e. no swapping occurs anymore. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/407f1f8ca19699e2eb2f46f8af4dd2de110be1d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M runtime/vm/log.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/log.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/log_test.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
Here is my second attempt at fixing nested log blockers. Note that the actual fix ...
3 years, 4 months ago (2017-08-11 22:07:34 UTC) #2
rmacnak
LGTM
3 years, 4 months ago (2017-08-12 00:05:07 UTC) #3
regis
3 years, 4 months ago (2017-08-14 15:38:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
407f1f8ca19699e2eb2f46f8af4dd2de110be1d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698