Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 299983002: Remove the NPAPI plugin from the webapp. (Closed)

Created:
6 years, 7 months ago by weitao
Modified:
6 years, 7 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the NPAPI plugin from the webapp. This change removes the NPAPI plugin from the webapp and switch Windows to use the Mac workflow where the user is prompted to download and install the host manually. The removal of the dispatching code and the NPAPI target will be done in later CLs. BUG=377046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272722

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -126 lines) Patch
M remoting/webapp/host_install_dialog.js View 3 chunks +32 lines, -54 lines 1 comment Download
M remoting/webapp/host_screen.js View 1 2 chunks +3 lines, -20 lines 1 comment Download
M remoting/webapp/host_setup_dialog.js View 2 chunks +5 lines, -21 lines 0 comments Download
M remoting/webapp/manifest.json.jinja2 View 1 2 chunks +14 lines, -26 lines 0 comments Download
M remoting/webapp/remoting.js View 1 chunk +4 lines, -5 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
weitao
6 years, 7 months ago (2014-05-24 00:52:32 UTC) #1
Jamie
lgtm
6 years, 7 months ago (2014-05-24 01:02:11 UTC) #2
Jamie
Can you create a separate bug just for the merge request and also link this ...
6 years, 7 months ago (2014-05-24 01:03:02 UTC) #3
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 7 months ago (2014-05-24 01:08:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/299983002/20001
6 years, 7 months ago (2014-05-24 01:10:08 UTC) #5
Sergey Ulanov
Please set BUG=377046
6 years, 7 months ago (2014-05-24 01:21:14 UTC) #6
Sergey Ulanov
lgtm, but please see my comments https://codereview.chromium.org/299983002/diff/20001/remoting/webapp/host_install_dialog.js File remoting/webapp/host_install_dialog.js (right): https://codereview.chromium.org/299983002/diff/20001/remoting/webapp/host_install_dialog.js#newcode30 remoting/webapp/host_install_dialog.js:30: /** @private*/ nit: ...
6 years, 7 months ago (2014-05-24 01:50:34 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:45:19 UTC) #8
Message was sent while issue was closed.
Change committed as 272722

Powered by Google App Engine
This is Rietveld 408576698