Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2999783002: Initial implementation of the kythe domain (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -120 lines) Patch
A pkg/analysis_server/lib/src/domain_kythe.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart View 16 chunks +67 lines, -117 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-10 16:00:57 UTC) #2
jwren
On 2017/08/10 16:00:57, Brian Wilkerson wrote: LGTM
3 years, 4 months ago (2017-08-10 18:40:15 UTC) #3
Brian Wilkerson
There aren't any tests for it yet, but it's an incremental step.
3 years, 4 months ago (2017-08-10 18:46:48 UTC) #4
Brian Wilkerson
3 years, 4 months ago (2017-08-10 18:49:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ecc72d6be5821f5656a896090e0c9103d43abeb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698